cluster/dm: add gloabl listen_host

nexustar commented 8 months ago

What problem does this PR solve?

close #2288
close #2300

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

codecov-commenter commented 8 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (eb2f058) 54.97% compared to head (3c40765) 50.36%.

:exclamation: Current head 3c40765 differs from pull request most recent head 6cecc2e. Consider uploading reports for the commit 6cecc2e to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2303 +/- ## ========================================== - Coverage 54.97% 50.36% -4.61% ========================================== Files 326 326 Lines 34700 34711 +11 ========================================== - Hits 19075 17481 -1594 - Misses 13342 15124 +1782 + Partials 2283 2106 -177 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2303/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2303/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `35.30% <84.62%> (-9.29%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2303/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.56% <0.00%> (-0.01%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2303/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.33% <53.33%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/pingcap/tiup/pull/2303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [pkg/cluster/spec/alertmanager.go](https://app.codecov.io/gh/pingcap/tiup/pull/2303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy9hbGVydG1hbmFnZXIuZ28=) | `64.80% <100.00%> (+2.40%)` | :arrow_up: | | [pkg/cluster/spec/cdc.go](https://app.codecov.io/gh/pingcap/tiup/pull/2303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy9jZGMuZ28=) | `42.45% <100.00%> (-12.05%)` | :arrow_down: | | [pkg/cluster/spec/drainer.go](https://app.codecov.io/gh/pingcap/tiup/pull/2303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy9kcmFpbmVyLmdv) | `49.74% <100.00%> (-4.43%)` | :arrow_down: | | [pkg/cluster/spec/grafana.go](https://app.codecov.io/gh/pingcap/tiup/pull/2303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy9ncmFmYW5hLmdv) | `61.70% <100.00%> (+0.16%)` | :arrow_up: | | [pkg/cluster/spec/monitoring.go](https://app.codecov.io/gh/pingcap/tiup/pull/2303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy9tb25pdG9yaW5nLmdv) | `72.15% <100.00%> (-0.99%)` | :arrow_down: | | [pkg/cluster/spec/pd.go](https://app.codecov.io/gh/pingcap/tiup/pull/2303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy9wZC5nbw==) | `38.44% <100.00%> (-26.19%)` | :arrow_down: | | [pkg/cluster/spec/pump.go](https://app.codecov.io/gh/pingcap/tiup/pull/2303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy9wdW1wLmdv) | `48.69% <100.00%> (-17.10%)` | :arrow_down: | | [pkg/cluster/spec/spec.go](https://app.codecov.io/gh/pingcap/tiup/pull/2303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy9zcGVjLmdv) | `80.80% <ø> (-2.80%)` | :arrow_down: | | [pkg/cluster/spec/tidb.go](https://app.codecov.io/gh/pingcap/tiup/pull/2303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy90aWRiLmdv) | `50.28% <100.00%> (-11.30%)` | :arrow_down: | | [pkg/cluster/spec/tiflash.go](https://app.codecov.io/gh/pingcap/tiup/pull/2303?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-cGtnL2NsdXN0ZXIvc3BlYy90aWZsYXNoLmdv) | `66.07% <100.00%> (-1.90%)` | :arrow_down: | | ... and [5 more](https://app.codecov.io/gh/pingcap/tiup/pull/2303?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | | ... and [49 files with indirect coverage changes](https://app.codecov.io/gh/pingcap/tiup/pull/2303/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ti-chi-bot[bot] commented 8 months ago

@KanShiori: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiup/pull/2303#pullrequestreview-1719237922): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

kaaaaaaang commented 8 months ago

/lgtm

ti-chi-bot[bot] commented 8 months ago

[LGTM Timeline notifier]

Timeline:

2023-11-08 03:00:22.526273533 +0000 UTC m=+3613220.113383670: :ballot_box_with_check: agreed by kaaaaaaang.

kaaaaaaang commented 8 months ago

/approve

ti-chi-bot[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / tiup