pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
411 stars 304 forks source link

playground/log: add mcs name for pd log #2310

Closed HuSharp closed 8 months ago

HuSharp commented 8 months ago

What problem does this PR solve?

What is changed and how it works?

change log name for pd mcs

run ./tiup-playground nightly --pd.mode ms --pd.api 3 --pd.tso 2 --pd.rm 1 before image

after image

Check List

Tests

Release notes:

NONE
HuSharp commented 8 months ago

cc @rleungx PTAL, thx!

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

codecov-commenter commented 8 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (da0221a) 53.39% compared to head (4dd84c7) 29.96%.

:exclamation: Current head 4dd84c7 differs from pull request most recent head a756742. Consider uploading reports for the commit a756742 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2310 +/- ## =========================================== - Coverage 53.39% 29.96% -23.43% =========================================== Files 325 311 -14 Lines 34725 32173 -2552 =========================================== - Hits 18540 9640 -8900 - Misses 13937 21447 +7510 + Partials 2248 1086 -1162 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2310/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2310/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `?` | | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2310/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `?` | | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2310/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.24% <0.00%> (-0.05%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2310/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.47% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2310/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.37% <0.00%> (-<0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/pingcap/tiup/pull/2310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [components/playground/instance/pd.go](https://app.codecov.io/gh/pingcap/tiup/pull/2310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-Y29tcG9uZW50cy9wbGF5Z3JvdW5kL2luc3RhbmNlL3BkLmdv) | `48.72% <ø> (ø)` | | | [components/playground/playground.go](https://app.codecov.io/gh/pingcap/tiup/pull/2310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#diff-Y29tcG9uZW50cy9wbGF5Z3JvdW5kL3BsYXlncm91bmQuZ28=) | `43.84% <0.00%> (-0.16%)` | :arrow_down: | ... and [204 files with indirect coverage changes](https://app.codecov.io/gh/pingcap/tiup/pull/2310/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaaaaaaang commented 8 months ago

/lgtm

ti-chi-bot[bot] commented 8 months ago

[LGTM Timeline notifier]

Timeline:

kaaaaaaang commented 8 months ago

/approve

ti-chi-bot[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment