pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
411 stars 304 forks source link

playground: Fix alignment of output #2313

Closed dveeden closed 8 months ago

dveeden commented 8 months ago

What problem does this PR solve?

tiup playground --tiproxy 1 v7.1.2:

Without this PR:

Connect TiDB:    mysql --comments --host 127.0.0.1 --port 4000 -u root
Connect TiProxy: mysql --comments --host 127.0.0.1 --port 6000 -u root
TiDB Dashboard:  http://127.0.0.1:2379/dashboard
Grafana:        http://127.0.0.1:3000

With this PR:

Connect TiDB:    mysql --comments --host 127.0.0.1 --port 4000 -u root
Connect TiProxy: mysql --comments --host 127.0.0.1 --port 36243 -u root
TiDB Dashboard:  http://127.0.0.1:2379/dashboard
Grafana:         http://127.0.0.1:3000

The line with Grafana: isn't aligned correctly

What is changed and how it works?

Check List

Tests

Related changes

Release notes:

NONE
codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (621598e) 55.52% compared to head (64e4082) 55.52%.

:exclamation: Current head 64e4082 differs from pull request most recent head 772f6f7. Consider uploading reports for the commit 772f6f7 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2313 +/- ## ======================================= Coverage 55.52% 55.52% ======================================= Files 325 325 Lines 34725 34725 ======================================= Hits 19281 19281 Misses 13142 13142 Partials 2302 2302 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2313/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.25% <100.00%> (ø)` | | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.48% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.38% <0.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaaaaaaang commented 8 months ago

/lgtm

kaaaaaaang commented 8 months ago

/approve

ti-chi-bot[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 8 months ago

[LGTM Timeline notifier]

Timeline:

ti-chi-bot[bot] commented 8 months ago

New changes are detected. LGTM label has been removed.

kaaaaaaang commented 8 months ago

/lgtm /approve