playground: make sure to signal tiproxy to stop

dveeden commented 8 months ago

What problem does this PR solve?

Closes #2317

What is changed and how it works?

Check List

Tests

Manual test (add detailed scripts or steps below)

Related changes

Need to cherry-pick to the release branch

Release notes:

TiUP Playground was updated to signal TiProxy to stop gracefully when stopping the playground.

codecov-commenter commented 8 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (bff409d) 55.52% compared to head (e638865) 55.51%.

:exclamation: Current head e638865 differs from pull request most recent head 76d8e8f. Consider uploading reports for the commit 76d8e8f to get more accurate results

Files	Patch %	Lines
components/playground/playground.go	0.00%	3 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2318 +/- ## ========================================== - Coverage 55.52% 55.51% -0.01% ========================================== Files 325 325 Lines 34725 34729 +4 ========================================== - Hits 19280 19278 -2 - Misses 13143 13147 +4 - Partials 2302 2304 +2 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2318/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2318/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.25% <0.00%> (-<0.01%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2318/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.48% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2318/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.38% <0.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaaaaaaang commented 8 months ago

/lgtm

kaaaaaaang commented 8 months ago

/approve

ti-chi-bot[bot] commented 8 months ago

@dveeden: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.

kaaaaaaang commented 8 months ago

/lgtm

ti-chi-bot[bot] commented 8 months ago

[LGTM Timeline notifier]

Timeline:

2023-11-15 05:45:08.721072042 +0000 UTC m=+4227906.308182188: :ballot_box_with_check: agreed by kaaaaaaang.
2023-11-15 05:45:29.060759743 +0000 UTC m=+4227926.647869884: :heavy_multiplication_x::repeat: reset by ti-chi-bot[bot].
2023-11-15 07:26:17.995436736 +0000 UTC m=+4233975.582546882: :ballot_box_with_check: agreed by kaaaaaaang.

kaaaaaaang commented 8 months ago

/approve

ti-chi-bot[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / tiup