add global component_sources

nexustar commented 1 year ago

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

codecov-commenter commented 1 year ago

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (520c05a) 55.52% compared to head (5d643a7) 50.69%.

:exclamation: Current head 5d643a7 differs from pull request most recent head 4ba7377. Consider uploading reports for the commit 4ba7377 to get more accurate results

Files	Patch %	Lines
pkg/cluster/spec/tikv_cdc.go	0.00%	7 Missing :warning:
components/dm/spec/logic.go	57.14%	4 Missing and 2 partials :warning:
pkg/cluster/spec/dashboard.go	0.00%	6 Missing :warning:
pkg/cluster/spec/instance.go	20.00%	2 Missing and 2 partials :warning:
pkg/cluster/spec/cdc.go	57.14%	2 Missing and 1 partial :warning:
pkg/cluster/spec/drainer.go	57.14%	2 Missing and 1 partial :warning:
pkg/cluster/spec/pd.go	57.14%	2 Missing and 1 partial :warning:
pkg/cluster/spec/pump.go	57.14%	2 Missing and 1 partial :warning:
pkg/cluster/spec/tidb.go	50.00%	2 Missing and 1 partial :warning:
pkg/cluster/spec/tiflash.go	57.14%	2 Missing and 1 partial :warning:
... and 2 more

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2320 +/- ## ========================================== - Coverage 55.52% 50.69% -4.83% ========================================== Files 325 325 Lines 34729 34753 +24 ========================================== - Hits 19280 17615 -1665 - Misses 13147 14997 +1850 + Partials 2302 2141 -161 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2320/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `37.65% <48.72%> (-7.23%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `25.45% <18.28%> (-0.02%)` | :arrow_down: | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.22% <0.00%> (-0.03%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.48% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2320/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.29% <6.45%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaaaaaaang commented 1 year ago

/lgtm

ti-chi-bot[bot] commented 1 year ago

[LGTM Timeline notifier]

Timeline:

2023-11-15 10:55:27.078226329 +0000 UTC m=+4246524.665336473: :ballot_box_with_check: agreed by kaaaaaaang.

kaaaaaaang commented 1 year ago

/merge

kaaaaaaang commented 1 year ago

/approve

ti-chi-bot[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / tiup