playground: fix metric targets will be overrided

xhebox commented 10 months ago

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Unit test
Integration test
[x] Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c3e9fc5) 55.52% compared to head (ca73d23) 55.52%.

:exclamation: Current head ca73d23 differs from pull request most recent head 06ce900. Consider uploading reports for the commit 06ce900 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2324 +/- ## ========================================== - Coverage 55.52% 55.52% -0.00% ========================================== Files 325 325 Lines 34753 34757 +4 ========================================== + Hits 19295 19296 +1 - Misses 13145 13147 +2 - Partials 2313 2314 +1 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2324/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.24% <100.00%> (+<0.01%)` | :arrow_up: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.48% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2324/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.30% <0.00%> (-<0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ti-chi-bot[bot] commented 10 months ago

[LGTM Timeline notifier]

Timeline:

2023-11-30 03:48:06.18855599 +0000 UTC m=+1067314.853782184: :ballot_box_with_check: agreed by kaaaaaaang.

kaaaaaaang commented 10 months ago

/lgtm

rleungx commented 10 months ago

/lgtm

ti-chi-bot[bot] commented 10 months ago

@rleungx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiup/pull/2324#issuecomment-1833175806): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

ti-chi-bot[bot] commented 10 months ago

@rleungx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiup/pull/2324#pullrequestreview-1756718678): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

kaaaaaaang commented 10 months ago

/approve

ti-chi-bot[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / tiup