pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
417 stars 310 forks source link

cluster: Add option to configure ng-monitoring continuous_profiling #2325

Open dveeden opened 10 months ago

dveeden commented 10 months ago

Feature Request

When using TiUP Cluster to deploy a TiDB Cluster one can set the ng_port to get ng-monitoring deployed as part of the cluster. Then one can enable continuous profiling as described here. However to automate deployment and make this persist on restarts of the cluster and cluster components it would be good to configure this in the configuration in the same way other cluster config is handled.

For ng-monitoring:

For tiup:

The workaround for now is to:

$ curl -s -X POST  -d '{"continuous_profiling":{"enable":true, "data_retention_seconds":259200}}' http://127.0.0.1:12020/config | jq .
{
  "status": "ok"
}
dveeden commented 10 months ago

/category monitoring /component cluster

dveeden commented 10 months ago

/component cluster