pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
417 stars 310 forks source link

Add check for rocky linux #2333

Closed dveeden closed 9 months ago

dveeden commented 9 months ago

What problem does this PR solve?

Rocky Linux 9.1 and later is listed in the documentation as supported, but the checks don't agree with this.

What is changed and how it works?

Add rocky linux to the check

See also:

Check List

Tests

Release notes:

NONE
dveeden commented 9 months ago

Note that there is one open issue related to Rocky Linux: https://github.com/pingcap/tiup/issues/2292 However I don't think that changes the support status.

/cc @jebter

codecov-commenter commented 9 months ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (c53895c) 55.53% compared to head (6698f56) 55.42%.

:exclamation: Current head 6698f56 differs from pull request most recent head c89a345. Consider uploading reports for the commit c89a345 to get more accurate results

Files Patch % Lines
pkg/cluster/operation/check.go 0.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2333 +/- ## ========================================== - Coverage 55.53% 55.42% -0.11% ========================================== Files 325 325 Lines 34757 34764 +7 ========================================== - Hits 19300 19265 -35 - Misses 13144 13187 +43 + Partials 2313 2312 -1 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2333/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `44.78% <0.00%> (-0.12%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `25.44% <0.00%> (-0.05%)` | :arrow_down: | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.24% <ø> (-0.02%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.48% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2333/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.29% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dveeden commented 9 months ago

Related: https://tidbcommunity.slack.com/archives/C019S7HLP61/p1702885355480039

kaaaaaaang commented 9 months ago

/lgtm

ti-chi-bot[bot] commented 9 months ago

[LGTM Timeline notifier]

Timeline:

kaaaaaaang commented 9 months ago

/merge

kaaaaaaang commented 9 months ago

/approve

ti-chi-bot[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment