pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
425 stars 312 forks source link

playground: print version when filling binpath #2334

Closed HuSharp closed 4 months ago

HuSharp commented 11 months ago

What problem does this PR solve?

When filling in the binpath, it isbetter to print out the instance using binpath

What is changed and how it works?

before

$ tiup playground v7.5.0 --pd.binpath /Users/pingcap/CS/PingCAP/pd/bin/pd-server
Start pd instance:v7.5.0
Start tikv instance:v7.5.0
Start tidb instance:v7.5.0

after

$ ./tiup-playground v8.1.0 --pd.mode ms --pd 1 --tiflash 0 --scheduling 3 --tso 2 --pd.binpath /Users/pingcap/CS/PingCAP/pd/bin/pd-server
Start pd instance:/Users/pingcap/CS/PingCAP/pd/bin/pd-server
Start pd instance:/Users/pingcap/CS/PingCAP/pd/bin/pd-server
Start pd instance:/Users/pingcap/CS/PingCAP/pd/bin/pd-server
Start pd instance:/Users/pingcap/CS/PingCAP/pd/bin/pd-server
Start pd instance:/Users/pingcap/CS/PingCAP/pd/bin/pd-server
Start pd instance:/Users/pingcap/CS/PingCAP/pd/bin/pd-server
Start tikv instance:v8.1.0
Start tidb instance:v8.1.0

Check List

Tests

Release notes:

print version when filling binpath
HuSharp commented 11 months ago

cc @lhy1024

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.91%. Comparing base (342c767) to head (b13c405). Report is 1 commits behind head on master.

:exclamation: Current head b13c405 differs from pull request most recent head af5f9ec

Please upload reports for the commit af5f9ec to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2334 +/- ## ========================================== - Coverage 55.22% 50.91% -4.32% ========================================== Files 334 328 -6 Lines 35982 34984 -998 ========================================== - Hits 19871 17810 -2061 - Misses 13726 14853 +1127 + Partials 2385 2321 -64 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2334/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2334/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.59% <ø> (-0.23%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2334/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ti-chi-bot[bot] commented 11 months ago

@lhy1024: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiup/pull/2334#pullrequestreview-1788066779): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 10 months ago

@nolouch: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiup/pull/2334#pullrequestreview-1803886027): >lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
HuSharp commented 4 months ago

PTAL, thx! @xhebox

ti-chi-bot[bot] commented 4 months ago

[LGTM Timeline notifier]

Timeline:

xhebox commented 4 months ago

/approve

ti-chi-bot[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [xhebox] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment