pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
425 stars 312 forks source link

cluster/dm: support deploying Prometheus witch custom command parameters #2340

Closed WalterWj closed 11 months ago

WalterWj commented 11 months ago

What problem does this PR solve?

Some users want to turn on Prometheus's hot load feature. Or add some Prometheus commands manually

What is changed and how it works?

img_v3_026g_107a4e8a-896d-4d8d-bf72-18df26c2131g img_v3_026g_1a83581c-afcd-4488-934e-3f8ea6ad203g

Check List

Tests

Code changes

Side effects

Related changes

Release notes:

NONE
CLAassistant commented 11 months ago

CLA assistant check
All committers have signed the CLA.

ti-chi-bot[bot] commented 11 months ago

Welcome @WalterWj! It looks like this is your first PR to pingcap/tiup 🎉

WalterWj commented 11 months ago

image image

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4800a90) 53.39% compared to head (a2ff03c) 55.33%.

:exclamation: Current head a2ff03c differs from pull request most recent head e1d2e70. Consider uploading reports for the commit e1d2e70 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2340 +/- ## ========================================== + Coverage 53.39% 55.33% +1.94% ========================================== Files 328 328 Lines 34823 34825 +2 ========================================== + Hits 18593 19270 +677 + Misses 13971 13242 -729 - Partials 2259 2313 +54 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2340/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2340/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `44.68% <100.00%> (+2.68%)` | :arrow_up: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2340/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `25.45% <100.00%> (-0.04%)` | :arrow_down: | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2340/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.29% <0.00%> (-<0.01%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2340/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.56% <ø> (-0.05%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2340/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.36% <0.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaaaaaaang commented 11 months ago

I think “additional_args” is a more clear name than "more_command"

WalterWj commented 11 months ago

Update run_command to additional_args image image

WalterWj commented 11 months ago

I think “additional_args” is a more clear name than "more_command"

Done

kaaaaaaang commented 11 months ago

/lgtm

kaaaaaaang commented 11 months ago

/approve

ti-chi-bot[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 11 months ago

@WalterWj: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 11 months ago

@WalterWj: Please do not delete or edit you lgtm type comment!

In response to [this](https://github.com/pingcap/tiup/pull/2340#pullrequestreview-1797617226): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 11 months ago

[LGTM Timeline notifier]

Timeline: