Closed WalterWj closed 11 months ago
Welcome @WalterWj! It looks like this is your first PR to pingcap/tiup 🎉
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
4800a90
) 53.39% compared to head (a2ff03c
) 55.33%.:exclamation: Current head a2ff03c differs from pull request most recent head e1d2e70. Consider uploading reports for the commit e1d2e70 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think “additional_args” is a more clear name than "more_command"
Update run_command to additional_args
I think “additional_args” is a more clear name than "more_command"
Done
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kaaaaaaang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@WalterWj: Your PR was out of date, I have automatically updated it for you.
@WalterWj: Please do not delete or edit you lgtm type comment!
Timeline:
2023-12-26 10:12:39.622997225 +0000 UTC m=+1560650.660224140
: :ballot_box_with_check: agreed by srstack.2023-12-27 02:55:58.394762489 +0000 UTC m=+1620849.431989414
: :heavy_multiplication_x::repeat: reset by WalterWj.2023-12-27 05:22:24.90362279 +0000 UTC m=+1629635.940849712
: :ballot_box_with_check: agreed by kaaaaaaang.2023-12-27 06:45:34.449214075 +0000 UTC m=+1634625.486441002
: :heavy_multiplication_x::repeat: reset by ti-chi-bot[bot].2023-12-28 02:33:39.467354155 +0000 UTC m=+1705910.504581067
: :ballot_box_with_check: agreed by srstack.
What problem does this PR solve?
Some users want to turn on Prometheus's hot load feature. Or add some Prometheus commands manually
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: