playground: tiproxy needs to override usercfg

xhebox commented 9 months ago

What problem does this PR solve?

Close #2339

previously, it doesnt override user config correctly leading to port conflicts when using custom configs for multiple tiproxy instances. TiDB pass ports by cli flags so then are fine.

Also, log-file is not passed

What is changed and how it works?

use different logic than TiDB to generate configs.
pass log-file

Check List

Tests

Unit test
Integration test
[x] Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

codecov-commenter commented 9 months ago

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (48b5119) 55.42% compared to head (4145baf) 55.05%. Report is 1 commits behind head on master.

:exclamation: Current head 4145baf differs from pull request most recent head 4df235a. Consider uploading reports for the commit 4df235a to get more accurate results

Files	Patch %	Lines
components/playground/instance/tiproxy.go	0.00%	16 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2342 +/- ## ========================================== - Coverage 55.42% 55.05% -0.37% ========================================== Files 328 328 Lines 34828 34827 -1 ========================================== - Hits 19300 19172 -128 - Misses 13218 13356 +138 + Partials 2310 2299 -11 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2342/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2342/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `44.30% <ø> (-0.44%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2342/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `25.45% <ø> (-0.02%)` | :arrow_down: | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2342/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.32% <0.00%> (+0.02%)` | :arrow_up: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2342/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.56% <ø> (-0.05%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2342/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.35% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaaaaaaang commented 9 months ago

/lgtm

kaaaaaaang commented 9 months ago

/approve

ti-chi-bot[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kaaaaaaang commented 9 months ago

/lgtm

ti-chi-bot[bot] commented 9 months ago

[LGTM Timeline notifier]

Timeline:

2023-12-28 09:10:40.996061608 +0000 UTC m=+1729732.033288530: :ballot_box_with_check: agreed by kaaaaaaang.
2023-12-29 07:22:51.806774186 +0000 UTC m=+1809662.844001113: :heavy_multiplication_x::repeat: reset by ti-chi-bot[bot].
2023-12-29 07:23:57.731474982 +0000 UTC m=+1809728.768701913: :ballot_box_with_check: agreed by kaaaaaaang.

pingcap / tiup