playground: fallback to default version when componen specific version is empty

xhebox commented 6 months ago

What problem does this PR solve?

Close #2343 . Fallback to default version when componen specific version is empty

Check List

Tests

Unit test
Integration test
[x] Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

codecov-commenter commented 6 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5618124) 53.39% compared to head (95bb130) 53.38%.

:exclamation: Current head 95bb130 differs from pull request most recent head 90147f3. Consider uploading reports for the commit 90147f3 to get more accurate results

Files	Patch %	Lines
components/playground/playground.go	83.33%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2344 +/- ## ========================================== - Coverage 53.39% 53.38% -0.01% ========================================== Files 328 328 Lines 34825 34828 +3 ========================================== - Hits 18593 18592 -1 - Misses 13973 13976 +3 - Partials 2259 2260 +1 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2344/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2344/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.31% <83.33%> (+0.01%)` | :arrow_up: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2344/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.56% <ø> (-0.05%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2344/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.35% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaaaaaaang commented 6 months ago

/lgtm

ti-chi-bot[bot] commented 6 months ago

[LGTM Timeline notifier]

Timeline:

2023-12-28 08:17:06.35516052 +0000 UTC m=+1726517.392387434: :ballot_box_with_check: agreed by kaaaaaaang.

kaaaaaaang commented 6 months ago

/approve

ti-chi-bot[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / tiup