pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
409 stars 304 forks source link

typo: fix `timedout` typo #2345

Closed HuSharp closed 6 months ago

HuSharp commented 6 months ago

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Release notes:

NONE
ti-chi-bot[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 6 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (48b5119) 53.38% compared to head (5f5bb91) 53.37%.

:exclamation: Current head 5f5bb91 differs from pull request most recent head eb87a40. Consider uploading reports for the commit eb87a40 to get more accurate results

Files Patch % Lines
pkg/cluster/executor/ssh.go 0.00% 2 Missing :warning:
pkg/exec/run.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2345 +/- ## ========================================== - Coverage 53.38% 53.37% -0.01% ========================================== Files 328 328 Lines 34828 34828 ========================================== - Hits 18591 18587 -4 - Misses 13978 13981 +3 - Partials 2259 2260 +1 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2345/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2345/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.56% <0.00%> (-0.05%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2345/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.35% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

breezewish commented 6 months ago

Timedout is typo of timed out instead of timeout:

HuSharp commented 6 months ago

Timedout is typo of timed out instead of timeout:

  • Timeout: n. Example: The timeout of an operation is 10 minutes.
  • Timed out: v. (past) Example: Timed out waiting for the operation to finish.

get it