pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
409 stars 304 forks source link

playground: fix can not set runtime config in config file & set TiFlash logger level to debug #2346

Closed Lloyd-Pottiger closed 6 months ago

Lloyd-Pottiger commented 6 months ago

What problem does this PR solve?

What is changed and how it works?

  1. Fix can not set runtime config in config file specific by --tiflash.config

now:

image image image image
  1. Since TiFlash has changed the default logger level to INFO, explicitly set the TiFlash logger level to DEBUG in TiUP playground to debug more easily.

Check List

Tests

Code changes

Side effects

Related changes

Release notes:

NONE
Lloyd-Pottiger commented 6 months ago

/cc @JaySon-Huang

ti-chi-bot[bot] commented 6 months ago

@Lloyd-Pottiger: GitHub didn't allow me to request PR reviews from the following users: JaySon-Huang.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/pingcap/tiup/pull/2346#issuecomment-1871674400): >/cc @JaySon-Huang Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov-commenter commented 6 months ago

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (0c6dda9) 55.40% compared to head (61ead98) 55.35%.

:exclamation: Current head 61ead98 differs from pull request most recent head 9bf6048. Consider uploading reports for the commit 9bf6048 to get more accurate results

Files Patch % Lines
components/playground/instance/tiflash.go 0.00% 37 Missing :warning:
components/playground/instance/tiflash_config.go 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2346 +/- ## ========================================== - Coverage 55.40% 55.35% -0.05% ========================================== Files 329 329 Lines 34845 34865 +20 ========================================== - Hits 19304 19297 -7 - Misses 13232 13257 +25 - Partials 2309 2311 +2 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2346/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2346/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.34% <0.00%> (-0.03%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2346/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.60% <ø> (-0.05%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2346/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.34% <ø> (-<0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Lloyd-Pottiger commented 6 months ago

/cc @breezewish

ti-chi-bot[bot] commented 6 months ago

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiup/pull/2346#pullrequestreview-1798607107): >LGTM Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
breezewish commented 6 months ago

Just curious, in what case do we need to override the runtime config in the config file? AFAIK for TiKV and TiDB these runtime configurations (like port) are also specified via parameters so that it will not be overridden by config files.

Lloyd-Pottiger commented 6 months ago

Just curious, in what case do we need to override the runtime config in the config file? AFAIK for TiKV and TiDB these runtime configurations (like port) are also specified via parameters so that it will not be overridden by config files.

case like:

My tiup installed in /data1, but /data1 is full and /data2 is almost empty

breezewish commented 6 months ago

/lgtm

Lloyd-Pottiger commented 6 months ago

/approve

Lloyd-Pottiger commented 6 months ago

/assign @kaaaaaaang

kaaaaaaang commented 6 months ago

/approve

kaaaaaaang commented 6 months ago

/lgtm /approve

kaaaaaaang commented 6 months ago

/lgtm

ti-chi-bot[bot] commented 6 months ago

[LGTM Timeline notifier]

Timeline:

kaaaaaaang commented 6 months ago

/approve

ti-chi-bot[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment