Closed Lloyd-Pottiger closed 6 months ago
/cc @JaySon-Huang
@Lloyd-Pottiger: GitHub didn't allow me to request PR reviews from the following users: JaySon-Huang.
Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.
Attention: 38 lines
in your changes are missing coverage. Please review.
Comparison is base (
0c6dda9
) 55.40% compared to head (61ead98
) 55.35%.:exclamation: Current head 61ead98 differs from pull request most recent head 9bf6048. Consider uploading reports for the commit 9bf6048 to get more accurate results
Files | Patch % | Lines |
---|---|---|
components/playground/instance/tiflash.go | 0.00% | 37 Missing :warning: |
components/playground/instance/tiflash_config.go | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/cc @breezewish
@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.
Just curious, in what case do we need to override the runtime config in the config file? AFAIK for TiKV and TiDB these runtime configurations (like port) are also specified via parameters so that it will not be overridden by config files.
Just curious, in what case do we need to override the runtime config in the config file? AFAIK for TiKV and TiDB these runtime configurations (like port) are also specified via parameters so that it will not be overridden by config files.
case like:
My tiup installed in /data1, but /data1 is full and /data2 is almost empty
/lgtm
/approve
/assign @kaaaaaaang
/approve
/lgtm /approve
/lgtm
Timeline:
2024-01-05 01:53:08.00379424 +0000 UTC m=+2394679.041021182
: :ballot_box_with_check: agreed by breezewish.2024-01-09 12:57:08.45415099 +0000 UTC m=+361618.038404678
: :heavy_multiplication_x::repeat: reset by ti-chi-bot[bot].2024-01-11 08:16:29.645276735 +0000 UTC m=+517579.229530422
: :ballot_box_with_check: agreed by kaaaaaaang./approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kaaaaaaang, Lloyd-Pottiger
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What problem does this PR solve?
What is changed and how it works?
--tiflash.config
now:
Check List
Tests
Code changes
Side effects
Related changes
Release notes: