pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
409 stars 304 forks source link

playground: Allow configuring pd.binpath for all PD microservices #2347

Closed breezewish closed 6 months ago

breezewish commented 6 months ago

What problem does this PR solve?

Currently, in PD microservice mode, users must specify binPath for each microservice, e.g.:

--pd.api.binpath=xxx
--pd.tso.binpath=xxx
...

After this PR, user can use one binPath for all microservices:

--pd.binpath=xxx    # Effective to all microservices

Users are also allowed to override binPath for particular microservice:

--pd.binpath=xxx    # Effective to all microservices except for TSO
--pd.tso.binpath=yyy

What is changed and how it works?

Check List

Tests

Code changes

Side effects

Related changes

Release notes:

NONE
codecov-commenter commented 6 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (768dea3) 55.40% compared to head (468e619) 55.40%.

:exclamation: Current head 468e619 differs from pull request most recent head b04896e. Consider uploading reports for the commit b04896e to get more accurate results

Files Patch % Lines
components/playground/main.go 0.00% 8 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2347 +/- ## ========================================== - Coverage 55.40% 55.40% -0.00% ========================================== Files 328 329 +1 Lines 34822 34836 +14 ========================================== + Hits 19291 19298 +7 - Misses 13225 13230 +5 - Partials 2306 2308 +2 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2347/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2347/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.37% <0.00%> (+0.05%)` | :arrow_up: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2347/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.56% <ø> (-0.05%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2347/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.34% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ti-chi-bot[bot] commented 6 months ago

@rleungx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiup/pull/2347#pullrequestreview-1800059325): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kaaaaaaang commented 6 months ago

/lgtm

kaaaaaaang commented 6 months ago

/approve

ti-chi-bot[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 6 months ago

[LGTM Timeline notifier]

Timeline:

ti-chi-bot[bot] commented 6 months ago

@breezewish: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
ti-chi-bot[bot] commented 6 months ago

New changes are detected. LGTM label has been removed.