Closed breezewish closed 6 months ago
Attention: 8 lines
in your changes are missing coverage. Please review.
Comparison is base (
768dea3
) 55.40% compared to head (468e619
) 55.40%.:exclamation: Current head 468e619 differs from pull request most recent head b04896e. Consider uploading reports for the commit b04896e to get more accurate results
Files | Patch % | Lines |
---|---|---|
components/playground/main.go | 0.00% | 8 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@rleungx: adding LGTM is restricted to approvers and reviewers in OWNERS files.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kaaaaaaang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Timeline:
2024-01-05 04:13:38.601087119 +0000 UTC m=+2403109.638314045
: :ballot_box_with_check: agreed by kaaaaaaang.2024-01-05 04:13:56.547707606 +0000 UTC m=+2403127.584934533
: :heavy_multiplication_x::repeat: reset by ti-chi-bot[bot].@breezewish: Your PR was out of date, I have automatically updated it for you.
New changes are detected. LGTM label has been removed.
What problem does this PR solve?
Currently, in PD microservice mode, users must specify binPath for each microservice, e.g.:
After this PR, user can use one binPath for all microservices:
Users are also allowed to override binPath for particular microservice:
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: