delete `logger.level` and `profiles.default.max_memory_usage` in tiflash default configs

windtalker commented 6 months ago

What problem does this PR solve?

delete logger.level and profiles.default.max_memory_usage in tiflash default configs since there is no need to set them explicitly in the config file.

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

CLAassistant commented 6 months ago

All committers have signed the CLA.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (90991fb) 55.53% compared to head (58fac00) 55.46%.

:exclamation: Current head 58fac00 differs from pull request most recent head fd21937. Consider uploading reports for the commit fd21937 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2348 +/- ## ========================================== - Coverage 55.53% 55.46% -0.07% ========================================== Files 328 328 Lines 34827 34825 -2 ========================================== - Hits 19340 19315 -25 - Misses 13175 13197 +22 - Partials 2312 2313 +1 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2348/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2348/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `44.83% <ø> (-0.07%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2348/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `25.45% <ø> (-0.04%)` | :arrow_down: | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2348/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.31% <ø> (-0.01%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2348/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.56% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2348/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.34% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ti-chi-bot[bot] commented 6 months ago

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiup/pull/2348#pullrequestreview-1802065459): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

JaySon-Huang commented 6 months ago

Related PR in tiflash:

https://github.com/pingcap/tiflash/pull/8569

Docs:

JaySon-Huang commented 6 months ago

@breezewish PTAL

kaaaaaaang commented 6 months ago

/lgtm

windtalker commented 6 months ago

/run-all-tests

kaaaaaaang commented 6 months ago

/hold

kaaaaaaang commented 6 months ago

/lgtm

ti-chi-bot[bot] commented 6 months ago

[LGTM Timeline notifier]

Timeline:

2024-01-04 03:00:06.179462439 +0000 UTC m=+2312297.216689365: :ballot_box_with_check: agreed by kaaaaaaang.
2024-01-04 07:13:48.495691742 +0000 UTC m=+2327519.532918657: :heavy_multiplication_x::repeat: reset by windtalker.
2024-01-04 07:34:09.899049525 +0000 UTC m=+2328740.936276452: :ballot_box_with_check: agreed by kaaaaaaang.

kaaaaaaang commented 6 months ago

/approve

ti-chi-bot[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / tiup