pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
409 stars 304 forks source link

support user mode systemd #2350

Closed Yujie-Xie closed 5 months ago

Yujie-Xie commented 6 months ago

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Code changes

Side effects

Related changes

Release notes:

NONE
CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

codecov-commenter commented 6 months ago

Codecov Report

Attention: 111 lines in your changes are missing coverage. Please review.

Comparison is base (0972f87) 55.54% compared to head (847bd74) 55.30%.

:exclamation: Current head 847bd74 differs from pull request most recent head 51374bc. Consider uploading reports for the commit 51374bc to get more accurate results

Files Patch % Lines
pkg/cluster/manager/deploy.go 43.48% 11 Missing and 2 partials :warning:
pkg/cluster/manager/scale_out.go 25.00% 10 Missing and 2 partials :warning:
pkg/cluster/operation/destroy.go 52.17% 6 Missing and 5 partials :warning:
pkg/cluster/spec/instance.go 37.50% 7 Missing and 3 partials :warning:
pkg/cluster/spec/tispark.go 37.50% 6 Missing and 4 partials :warning:
pkg/cluster/manager/check.go 68.97% 5 Missing and 4 partials :warning:
pkg/cluster/task/monitored_config.go 35.71% 5 Missing and 4 partials :warning:
pkg/cluster/operation/action.go 79.49% 0 Missing and 8 partials :warning:
pkg/cluster/task/env_init.go 53.33% 5 Missing and 2 partials :warning:
pkg/cluster/task/mkdir.go 57.14% 5 Missing and 1 partial :warning:
... and 7 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2350 +/- ## ========================================== - Coverage 55.54% 55.30% -0.23% ========================================== Files 329 329 Lines 34869 35020 +151 ========================================== + Hits 19365 19367 +2 - Misses 13190 13322 +132 - Partials 2314 2331 +17 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2350/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `44.69% <62.63%> (-0.23%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `25.55% <40.74%> (+0.02%)` | :arrow_up: | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.31% <0.00%> (-0.04%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.60% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2350/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.24% <0.93%> (-0.10%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaaaaaaang commented 5 months ago

/lgtm

kaaaaaaang commented 5 months ago

/approve

ti-chi-bot[bot] commented 5 months ago

@Yujie-Xie: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
kaaaaaaang commented 5 months ago

/lgtm

ti-chi-bot[bot] commented 5 months ago

[LGTM Timeline notifier]

Timeline:

kaaaaaaang commented 5 months ago

/approve

ti-chi-bot[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment