pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
417 stars 310 forks source link

playground: init some pd configuration #2351

Closed nolouch closed 9 months ago

nolouch commented 9 months ago

What problem does this PR solve?

close https://github.com/tikv/pd/issues/7507

What is changed and how it works?

Check List

Tests

After:

image config:

➜  pd-0 cat pd.toml
[schedule]
patrol-region-interval = "100ms"

Release notes:

NONE
ti-chi-bot[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 9 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9acd306) 55.38% compared to head (8397fc2) 55.54%.

:exclamation: Current head 8397fc2 differs from pull request most recent head 292fae3. Consider uploading reports for the commit 292fae3 to get more accurate results

Files Patch % Lines
components/playground/instance/pd.go 70.00% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2351 +/- ## ========================================== + Coverage 55.38% 55.54% +0.16% ========================================== Files 328 329 +1 Lines 34825 34836 +11 ========================================== + Hits 19287 19349 +62 + Misses 13230 13175 -55 - Partials 2308 2312 +4 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2351/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.37% <78.57%> (+0.05%)` | :arrow_up: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.56% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.34% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ti-chi-bot[bot] commented 9 months ago

[LGTM Timeline notifier]

Timeline: