Closed nolouch closed 9 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
9acd306
) 55.38% compared to head (8397fc2
) 55.54%.:exclamation: Current head 8397fc2 differs from pull request most recent head 292fae3. Consider uploading reports for the commit 292fae3 to get more accurate results
Files | Patch % | Lines |
---|---|---|
components/playground/instance/pd.go | 70.00% | 2 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Timeline:
2024-01-05 01:50:45.101358579 +0000 UTC m=+2394536.138585506
: :ballot_box_with_check: agreed by breezewish.
What problem does this PR solve?
close https://github.com/tikv/pd/issues/7507
What is changed and how it works?
Check List
Tests
Before:
After:
config:
Release notes: