cluster: fix tiproxy config and version

xhebox commented 10 months ago

What problem does this PR solve?

1, require-backend-tls is useless

now we use nightly version by default
fix a bug where configs are lost

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

kaaaaaaang commented 10 months ago

I do not think it is a good idea to use nightly by default in tiup-cluster. For example，user may use tiup-cluster v1.14.1 years later.

xhebox commented 10 months ago

I do not think it is a good idea to use nightly by default in tiup-cluster. For example，user may use tiup-cluster v1.14.1 years later.

Addressed. Fallback to "" by default. Or "nightly", if either component version or cluster version is.

codecov-commenter commented 10 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (1210bc2) 55.53% compared to head (baa7cac) 55.31%.

:exclamation: Current head baa7cac differs from pull request most recent head 0470547. Consider uploading reports for the commit 0470547 to get more accurate results

Files	Patch %	Lines
pkg/cluster/spec/tiproxy.go	50.00%	3 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2354 +/- ## ========================================== - Coverage 55.53% 55.31% -0.22% ========================================== Files 329 329 Lines 34836 34841 +5 ========================================== - Hits 19344 19270 -74 - Misses 13179 13258 +79 Partials 2313 2313 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2354/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2354/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `44.63% <50.00%> (-0.25%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2354/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `25.45% <0.00%> (-0.04%)` | :arrow_down: | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2354/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.36% <0.00%> (-0.01%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2354/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.59% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2354/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.34% <0.00%> (-<0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaaaaaaang commented 10 months ago

/lgtm

ti-chi-bot[bot] commented 10 months ago

[LGTM Timeline notifier]

Timeline:

2024-01-09 06:24:47.467723656 +0000 UTC m=+338077.051977328: :ballot_box_with_check: agreed by kaaaaaaang.

kaaaaaaang commented 10 months ago

/approve

ti-chi-bot[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / tiup