pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
409 stars 304 forks source link

cluster: fix TLS configs for tiproxy #2356

Closed xhebox closed 6 months ago

xhebox commented 6 months ago

What problem does this PR solve?

  1. server-tls of tidb is manually specified, so does tiproxy's server-tls. Instead, for newer tiproxy, server-http-tls should be specified.
  2. topo.GlobalOptions.TLSEnabled is not passed to setTLSConfig.
  3. remove schema:// and be consistent with tidb

Check List

Tests

Code changes

Side effects

Related changes

Release notes:

NONE
codecov-commenter commented 6 months ago

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (30d4413) 55.43% compared to head (d64dbf0) 55.42%.

:exclamation: Current head d64dbf0 differs from pull request most recent head 653fb94. Consider uploading reports for the commit 653fb94 to get more accurate results

Files Patch % Lines
pkg/cluster/spec/tiproxy.go 0.00% 14 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2356 +/- ## ========================================== - Coverage 55.43% 55.42% -0.01% ========================================== Files 329 329 Lines 34838 34845 +7 ========================================== Hits 19310 19310 - Misses 13216 13223 +7 Partials 2312 2312 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2356/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2356/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.60% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2356/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.33% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaaaaaaang commented 6 months ago

/lgtm

kaaaaaaang commented 6 months ago

/approve

ti-chi-bot[bot] commented 6 months ago

@xhebox: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
kaaaaaaang commented 6 months ago

/lgtm

kaaaaaaang commented 6 months ago

/approve

ti-chi-bot[bot] commented 6 months ago

[LGTM Timeline notifier]

Timeline:

ti-chi-bot[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment