Closed xhebox closed 6 months ago
Attention: 14 lines
in your changes are missing coverage. Please review.
Comparison is base (
30d4413
) 55.43% compared to head (d64dbf0
) 55.42%.:exclamation: Current head d64dbf0 differs from pull request most recent head 653fb94. Consider uploading reports for the commit 653fb94 to get more accurate results
Files | Patch % | Lines |
---|---|---|
pkg/cluster/spec/tiproxy.go | 0.00% | 14 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/lgtm
/approve
@xhebox: Your PR was out of date, I have automatically updated it for you.
/lgtm
/approve
Timeline:
2024-01-09 12:57:42.700564297 +0000 UTC m=+361652.284817983
: :ballot_box_with_check: agreed by kaaaaaaang.2024-01-10 08:11:57.320143046 +0000 UTC m=+430906.904396718
: :heavy_multiplication_x::repeat: reset by xhebox.2024-01-11 07:42:02.292582952 +0000 UTC m=+515511.876836638
: :ballot_box_with_check: agreed by kaaaaaaang.[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kaaaaaaang
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What problem does this PR solve?
server-tls
of tidb is manually specified, so does tiproxy'sserver-tls
. Instead, for newer tiproxy,server-http-tls
should be specified.topo.GlobalOptions.TLSEnabled
is not passed tosetTLSConfig
.schema://
and be consistent with tidbCheck List
Tests
Code changes
Side effects
Related changes
Release notes: