pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
425 stars 312 forks source link

cluster/tiflash: Remove deprecated config items #2357

Open JaySon-Huang opened 10 months ago

JaySon-Huang commented 10 months ago

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Code changes

Side effects

Related changes

Release notes:

NONE
ti-chi-bot[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3b246a3) 55.43% compared to head (12e12af) 55.39%.

:exclamation: Current head 12e12af differs from pull request most recent head fbe2708. Consider uploading reports for the commit fbe2708 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2357 +/- ## ========================================== - Coverage 55.43% 55.39% -0.05% ========================================== Files 329 329 Lines 34841 34848 +7 ========================================== - Hits 19314 19302 -12 - Misses 13216 13235 +19 Partials 2311 2311 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2357/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2357/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `44.71% <96.55%> (-0.04%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2357/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `25.44% <0.00%> (-0.01%)` | :arrow_down: | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2357/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.37% <0.00%> (+<0.01%)` | :arrow_up: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2357/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.59% <ø> (-0.05%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2357/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.36% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.