Open JaySon-Huang opened 10 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
3b246a3
) 55.43% compared to head (12e12af
) 55.39%.:exclamation: Current head 12e12af differs from pull request most recent head fbe2708. Consider uploading reports for the commit fbe2708 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
What problem does this PR solve?
What is changed and how it works?
default_profile
/display_name
/tmp_path
is no longer need since v5.4.0 (https://github.com/pingcap/tiflash/pull/3414)flash.flash_cluster
is no longer need since v6.0.0 (https://github.com/pingcap/tidb/issues/29924)Check List
Tests
Code changes
Side effects
Related changes
Release notes: