cluster: fix tiproxy will restart even if version is the same

xhebox commented 10 months ago

What problem does this PR solve?

Restart tiproxy iff version becomes different after --tiproxyversion or new cluster version(only nightly is possible though).

Tests

Unit test
Integration test
[x] Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

codecov-commenter commented 10 months ago

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (0c6dda9) 55.40% compared to head (0bc8dd9) 55.44%. Report is 2 commits behind head on master.

:exclamation: Current head 0bc8dd9 differs from pull request most recent head 6a4c5d4. Consider uploading reports for the commit 6a4c5d4 to get more accurate results

Files	Patch %	Lines
components/playground/instance/tiflash.go	7.14%	26 Missing :warning:
components/playground/instance/tiflash_config.go	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2358 +/- ## ========================================== + Coverage 55.40% 55.44% +0.05% ========================================== Files 329 329 Lines 34845 34849 +4 ========================================== + Hits 19304 19322 +18 + Misses 13232 13214 -18 - Partials 2309 2313 +4 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2358/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2358/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `44.76% <100.00%> (+0.04%)` | :arrow_up: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2358/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `25.53% <100.00%> (+0.03%)` | :arrow_up: | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2358/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.37% <6.90%> (-0.01%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2358/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.60% <ø> (-0.05%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2358/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.33% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.