tiup: fix cannot clone without global version

nexustar commented 10 months ago

What problem does this PR solve?

fix #2336

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

kaaaaaaang commented 10 months ago

/lgtm

kaaaaaaang commented 10 months ago

/approve

ti-chi-bot[bot] commented 10 months ago

[LGTM Timeline notifier]

Timeline:

2024-01-10 17:26:36.730336162 +0000 UTC m=+464186.314589856: :ballot_box_with_check: agreed by kaaaaaaang.

ti-chi-bot[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3b246a3) 55.43% compared to head (24e3190) 35.75%.

:exclamation: Current head 24e3190 differs from pull request most recent head c4c6113. Consider uploading reports for the commit c4c6113 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2359 +/- ## =========================================== - Coverage 55.43% 35.75% -19.68% =========================================== Files 329 251 -78 Lines 34841 27429 -7412 =========================================== - Hits 19314 9807 -9507 - Misses 13216 16342 +3126 + Partials 2311 1280 -1031 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2359/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2359/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `35.75% <ø> (-9.00%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2359/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `?` | | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2359/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `?` | | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2359/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `?` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2359/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pingcap / tiup