playground: only pull nightly from cluster version

xhebox commented 8 months ago

What problem does this PR solve?

tiup playground v7.5.0 --tiproxy 1 will fail since bindVersion = "v7.5.0". We should only pull nightly instead.

Check List

Tests

Unit test
Integration test
[x] Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

codecov-commenter commented 8 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (79c584f) 55.78% compared to head (22d4bbb) 54.51%.

:exclamation: Current head 22d4bbb differs from pull request most recent head c5007e6. Consider uploading reports for the commit c5007e6 to get more accurate results

Files	Patch %	Lines
components/playground/playground.go	0.00%	2 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2364 +/- ## ========================================== - Coverage 55.78% 54.51% -1.27% ========================================== Files 329 329 Lines 35024 35783 +759 ========================================== - Hits 19537 19507 -30 - Misses 13143 13940 +797 + Partials 2344 2336 -8 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2364/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2364/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.19% <0.00%> (-0.14%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2364/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.60% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2364/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.33% <0.00%> (+0.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaaaaaaang commented 8 months ago

/lgtm

kaaaaaaang commented 8 months ago

/approve

ti-chi-bot[bot] commented 8 months ago

@xhebox: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.

kaaaaaaang commented 8 months ago

/lgtm

kaaaaaaang commented 8 months ago

/approve

ti-chi-bot[bot] commented 8 months ago

[LGTM Timeline notifier]

Timeline:

2024-01-15 09:33:17.63350607 +0000 UTC m=+175639.197803760: :ballot_box_with_check: agreed by kaaaaaaang.
2024-01-15 13:49:53.966759728 +0000 UTC m=+191035.531057434: :heavy_multiplication_x::repeat: reset by xhebox.
2024-02-02 09:49:24.279926773 +0000 UTC m=+1731805.844224478: :ballot_box_with_check: agreed by kaaaaaaang.
2024-02-02 09:49:40.490085395 +0000 UTC m=+1731822.054383100: :heavy_multiplication_x::repeat: reset by ti-chi-bot[bot].
2024-02-02 09:54:45.232361872 +0000 UTC m=+1732126.796659579: :ballot_box_with_check: agreed by kaaaaaaang.

ti-chi-bot[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / tiup