pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
417 stars 310 forks source link

playground: fix tiproxy scale #2365

Closed xhebox closed 7 months ago

xhebox commented 8 months ago

What problem does this PR solve?

missing sanitizeComponentConfig.

Check List

Tests

Code changes

Side effects

Related changes

Release notes:

Fix tiproxy playground scale out
codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.91%. Comparing base (38b6c96) to head (5913469).

:exclamation: Current head 5913469 differs from pull request most recent head d7a4bce. Consider uploading reports for the commit d7a4bce to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2365 +/- ## ========================================== + Coverage 55.77% 55.91% +0.14% ========================================== Files 329 329 Lines 35025 35032 +7 ========================================== + Hits 19534 19586 +52 + Misses 13154 13110 -44 + Partials 2337 2336 -1 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2365/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2365/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `45.13% <ø> (-0.18%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2365/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `25.51% <ø> (-0.05%)` | :arrow_down: | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2365/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.79% <100.00%> (+0.62%)` | :arrow_up: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2365/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.60% <ø> (-0.05%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2365/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.24% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaaaaaaang commented 8 months ago

/approve

ti-chi-bot[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
xhebox commented 8 months ago

/retest

kaaaaaaang commented 7 months ago

/lgtm

ti-chi-bot[bot] commented 7 months ago

[LGTM Timeline notifier]

Timeline:

kaaaaaaang commented 7 months ago

/approve