cluster: skip tiproxy download & copy

xhebox commented 5 months ago

What problem does this PR solve?

Some components has different Role() and Name(). FilterComponent is a mixed of filtering by Name() and Role(), thus we need to add both into the filter set.

Check List

Tests

Unit test
Integration test
[x] Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.94%. Comparing base (bb648c3) to head (520a442). Report is 1 commits behind head on master.

:exclamation: Current head 520a442 differs from pull request most recent head 588189e. Consider uploading reports for the commit 588189e to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2366 +/- ## ========================================== - Coverage 56.07% 55.94% -0.13% ========================================== Files 329 329 Lines 35034 35040 +6 ========================================== - Hits 19644 19603 -41 - Misses 13053 13100 +47 Partials 2337 2337 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2366/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2366/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `45.18% <100.00%> (-0.13%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2366/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `25.52% <100.00%> (-0.03%)` | :arrow_down: | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2366/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.78% <ø> (ø)` | | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2366/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.59% <ø> (-0.05%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2366/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.22% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xhebox commented 5 months ago

/retest

kaaaaaaang commented 4 months ago

/lgtm

kaaaaaaang commented 4 months ago

/approve

kaaaaaaang commented 4 months ago

/lgtm

kaaaaaaang commented 4 months ago

/approve

ti-chi-bot[bot] commented 4 months ago

[LGTM Timeline notifier]

Timeline:

2024-02-29 09:56:13.554025538 +0000 UTC m=+1128662.301648646: :ballot_box_with_check: agreed by kaaaaaaang.
2024-03-06 02:32:01.686474034 +0000 UTC m=+220748.708720422: :heavy_multiplication_x::repeat: reset by ti-chi-bot[bot].
2024-03-06 07:54:02.920147684 +0000 UTC m=+240069.942394072: :ballot_box_with_check: agreed by kaaaaaaang.

ti-chi-bot[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / tiup