playground: set tiproxy addr without schema

xhebox commented 5 months ago

What problem does this PR solve?

If user sets TLS for PD endpoints, then tiproxy or etcd/client/v3 is not able to use TLS since http://... is passed to etcd client. Check https://github.com/etcd-io/etcd/blob/main/client/v3/internal/endpoint/endpoint.go#L90-L118. However, when only host:port is passed, the TLS config will be used.

Check List

Tests

Unit test
Integration test
[x] Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

codecov-commenter commented 5 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c72f4e0) 55.76% compared to head (76a0297) 55.76%.

:exclamation: Current head 76a0297 differs from pull request most recent head 891f79e. Consider uploading reports for the commit 891f79e to get more accurate results

Files	Patch %	Lines
components/playground/instance/tiproxy.go	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2368 +/- ## ======================================= Coverage 55.76% 55.76% ======================================= Files 329 329 Lines 35024 35024 ======================================= Hits 19531 19531 Misses 13149 13149 Partials 2344 2344 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2368/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2368/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.34% <0.00%> (+0.01%)` | :arrow_up: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2368/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.60% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2368/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.24% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaaaaaaang commented 5 months ago

/lgtm

kaaaaaaang commented 5 months ago

/approve

ti-chi-bot[bot] commented 5 months ago

@xhebox: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.

kaaaaaaang commented 5 months ago

/lgtm

ti-chi-bot[bot] commented 5 months ago

[LGTM Timeline notifier]

Timeline:

2024-01-31 03:27:07.902101216 +0000 UTC m=+1536069.466398922: :ballot_box_with_check: agreed by kaaaaaaang.
2024-01-31 07:16:39.33685722 +0000 UTC m=+1549840.901154920: :heavy_multiplication_x::repeat: reset by ti-chi-bot[bot].
2024-01-31 07:59:24.857260746 +0000 UTC m=+1552406.421558450: :ballot_box_with_check: agreed by kaaaaaaang.

kaaaaaaang commented 5 months ago

/approve

ti-chi-bot[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / tiup