pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
409 stars 304 forks source link

cluster: add integration tests for tiproxy #2371

Closed xhebox closed 5 months ago

xhebox commented 5 months ago

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Code changes

Side effects

Related changes

Release notes:

NONE
codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5811bbb) 55.36% compared to head (0a62110) 52.98%.

:exclamation: Current head 0a62110 differs from pull request most recent head 3ef2893. Consider uploading reports for the commit 3ef2893 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2371 +/- ## ========================================== - Coverage 55.36% 52.98% -2.38% ========================================== Files 329 329 Lines 35020 35020 ========================================== - Hits 19388 18554 -834 - Misses 13298 14244 +946 + Partials 2334 2222 -112 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2371/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2371/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `42.50% <ø> (-2.24%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2371/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `18.96% <ø> (-6.55%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2371/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.60% <ø> (-0.05%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2371/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.24% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaaaaaaang commented 5 months ago

/lgtm

kaaaaaaang commented 5 months ago

/approve

ti-chi-bot[bot] commented 5 months ago

@xhebox: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.
kaaaaaaang commented 5 months ago

/lgtm

ti-chi-bot[bot] commented 5 months ago

[LGTM Timeline notifier]

Timeline:

kaaaaaaang commented 5 months ago

/approve

ti-chi-bot[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment