pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
409 stars 304 forks source link

Fix timeout when checking component upgrade #2379

Closed KanShiori closed 4 months ago

KanShiori commented 4 months ago

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Code changes

Side effects

Related changes

Release notes:

NONE
codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 50.09%. Comparing base (8164c78) to head (8d3f9dd).

:exclamation: Current head 8d3f9dd differs from pull request most recent head e3423d9. Consider uploading reports for the commit e3423d9 to get more accurate results

Files Patch % Lines
pkg/exec/run.go 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2379 +/- ## ========================================== - Coverage 56.03% 50.09% -5.95% ========================================== Files 329 329 Lines 35032 35034 +2 ========================================== - Hits 19630 17548 -2082 - Misses 13063 15365 +2302 + Partials 2339 2121 -218 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2379/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2379/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `35.33% <ø> (-9.96%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2379/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `25.51% <ø> (ø)` | | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2379/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.59% <0.00%> (-0.01%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2379/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.24% <ø> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ti-chi-bot[bot] commented 4 months ago

[LGTM Timeline notifier]

Timeline:

kaaaaaaang commented 4 months ago

/approve

ti-chi-bot[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment