search

pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
427 stars 313 forks source link

playground: remove resource manager #2381

Closed rleungx closed 8 months ago

rleungx commented 8 months ago

What problem does this PR solve?

Resource manager microservice is never fully tested. So I'm going to remove it to avoid misleading the users.

What is changed and how it works?

Check List

Tests

🎉 TiDB Playground Cluster is started, enjoy!

Connect TiDB: mysql --comments --host 10.2.8.101 --port 37777 -u root TiDB Dashboard: http://10.2.8.101:38999/dashboard Grafana: http://10.2.8.101:39125


Side effects

 - Breaking backward compatibility

Release notes:
<!--
If no, just leave the release note block below as is.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
Please refer to [Release Notes Language Style Guide](https://github.com/pingcap/tiup/blob/master/doc/dev/release-note-guide.md) before writing the release note.
-->
```release-note
NONE
ti-chi-bot[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 41.93548% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 56.03%. Comparing base (9e11d0e) to head (e6a73dd). Report is 4 commits behind head on master.

:exclamation: Current head e6a73dd differs from pull request most recent head 7c18c80. Consider uploading reports for the commit 7c18c80 to get more accurate results

Files Patch % Lines
components/playground/main.go 40.00% 9 Missing :warning:
components/playground/playground.go 22.22% 5 Missing and 2 partials :warning:
components/playground/instance/instance.go 0.00% 0 Missing and 1 partial :warning:
components/playground/instance/pd.go 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2381 +/- ## ========================================== - Coverage 56.07% 56.03% -0.03% ========================================== Files 329 329 Lines 35040 34998 -42 ========================================== - Hits 19646 19611 -35 + Misses 13056 13050 -6 + Partials 2338 2337 -1 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2381/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `45.25% <100.00%> (-0.07%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `25.52% <100.00%> (-0.05%)` | :arrow_down: | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `15.75% <38.71%> (-0.04%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.59% <ø> (-0.05%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2381/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.26% <0.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ti-chi-bot[bot] commented 8 months ago

[LGTM Timeline notifier]

Timeline:

kaaaaaaang commented 8 months ago

/lgtm