Closed djshow832 closed 3 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Attention: Patch coverage is 58.71560%
with 45 lines
in your changes are missing coverage. Please review.
Project coverage is 55.95%. Comparing base (
ddbbc4d
) to head (5171187
). Report is 2 commits behind head on master.:exclamation: Current head 5171187 differs from pull request most recent head b365889. Consider uploading reports for the commit b365889 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Timeline:
2024-03-28 03:57:12.789481564 +0000 UTC m=+2126659.811727950
: :ballot_box_with_check: agreed by kaaaaaaang.
What problem does this PR solve?
2391
TiProxy reports its IP, instead of its DNS to ETCD.
What is changed and how it works?
Add config
advertise-addr
to tiproxy spec. Note that it's compatible with old TiProxy versions because TiProxy won't report errors if there's an unknown config.Check List
Tests
With Playground:
With Cluster:
Code changes
None
Side effects
None
Related changes
None
Release notes: