pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
425 stars 312 forks source link

playground/pdms: wait for tso component ready #2394

Closed HuSharp closed 7 months ago

HuSharp commented 7 months ago

What problem does this PR solve?

Close #2396

What is changed and how it works?

can reload cluster with tag

image

Check List

Tests

Code changes

Side effects

Related changes

Release notes:

NONE
ti-chi-bot[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 16.66667% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 50.50%. Comparing base (48f15f4) to head (c4558b2). Report is 1 commits behind head on master.

:exclamation: Current head c4558b2 differs from pull request most recent head a7a3cbf. Consider uploading reports for the commit a7a3cbf to get more accurate results

Files Patch % Lines
pkg/cluster/api/pdapi.go 0.00% 20 Missing :warning:
components/playground/instance/tikv.go 30.00% 13 Missing and 1 partial :warning:
components/playground/playground.go 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2394 +/- ## ========================================== - Coverage 55.81% 50.50% -5.31% ========================================== Files 329 329 Lines 35222 35258 +36 ========================================== - Hits 19657 17805 -1852 - Misses 13200 15303 +2103 + Partials 2365 2150 -215 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2394/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2394/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `36.03% <0.00%> (-9.07%)` | :arrow_down: | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2394/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `16.36% <16.67%> (-0.01%)` | :arrow_down: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2394/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.59% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2394/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.15% <0.00%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ti-chi-bot[bot] commented 7 months ago

@rleungx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiup/pull/2394#pullrequestreview-1971001118): >The rest LGTM Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kaaaaaaang commented 7 months ago

please fix the UT

HuSharp commented 7 months ago

please fix the UT

Fixed. But not sure why get [ERROR] Please install docker-compose in integrate-cluster-cmd :(

kaaaaaaang commented 7 months ago

/lgtm

ti-chi-bot[bot] commented 7 months ago

[LGTM Timeline notifier]

Timeline:

seiya-annie commented 5 months ago

/found community

seiya-annie commented 5 months ago

/found community