Revert "playground: only pull nightly from cluster version (#2364)"

kaaaaaaang commented 7 months ago

This reverts commit 38b6c96c2d27f16bbc7fd95644235010d319f6cc.

What problem does this PR solve?

fix #2395

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

ti-chi-bot[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from kaaaaaaang, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.83%. Comparing base (48f15f4) to head (db3303b).

:exclamation: Current head db3303b differs from pull request most recent head 1a90efb. Consider uploading reports for the commit 1a90efb to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2397 +/- ## ========================================== + Coverage 55.80% 55.83% +0.03% ========================================== Files 329 329 Lines 35222 35221 -1 ========================================== + Hits 19654 19663 +9 + Misses 13202 13187 -15 - Partials 2366 2371 +5 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2397/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2397/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `16.52% <100.00%> (+0.16%)` | :arrow_up: | | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2397/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.59% <ø> (ø)` | | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2397/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `22.16% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pingcap / tiup