Closed dveeden closed 2 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Attention: Patch coverage is 0%
with 3 lines
in your changes are missing coverage. Please review.
Project coverage is 55.93%. Comparing base (
6f01692
) to head (d11e769
).:exclamation: Current head d11e769 differs from pull request most recent head 5ab50e4. Consider uploading reports for the commit 5ab50e4 to get more accurate results
Files | Patch % | Lines |
---|---|---|
cmd/mirror.go | 0.00% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
/lgtm
Timeline:
2024-04-09 12:20:06.272743816 +0000 UTC m=+964867.800284360
: :ballot_box_with_check: agreed by kaaaaaaang.
What problem does this PR solve?
GetComponentManifest()
can return a nil manifest if it returns an error.newMirrorRenewCmd()
ignores expiration errors when callingGetComponentManifest()
. It should make sure that the manifest is not nil when callingRenewManifest()
.ref #2398
What is changed and how it works?
Check List
Tests
Release notes: