Closed negachov closed 4 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Welcome @negachov! It looks like this is your first PR to pingcap/tiup π
+1 for this PR. The port 3000 is also the standard port in the Ruby on Rails community because it is the default port for running Rails in a local development environment. It is better to have an option to avoid conflicts.
Timeline:
2024-04-14 15:48:00.951249029 +0000 UTC m=+180300.062295479
: :ballot_box_with_check: agreed by breezewish./merge
@breezewish It seems it stacked at tide check. Do you know if there is anything to do before merging?
@bohnen Merged manually. Thanks for the report.
What problem does this PR solve?
The Grafana port is fixed at 3000 and cannot be changed.
What is changed and how it works?
I have made it possible to specify the Grafana port via options.
Check List
Tests
Note: Version constraint is resolved to v8.0.0. If you'd like to use other versions:
Start pd instance:v8.0.0 Start tikv instance:v8.0.0 Start tidb instance:v8.0.0 Waiting for tidb instances ready 127.0.0.1:4000 ... Done Start tiflash instance:v8.0.0 Waiting for tiflash instances ready 127.0.0.1:3930 ... Done
π TiDB Playground Cluster is started, enjoy!
Connect TiDB: mysql --comments --host 127.0.0.1 --port 4000 -u root TiDB Dashboard: http://127.0.0.1:2379/dashboard Grafana: http://127.0.0.1:3333