pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
417 stars 310 forks source link

Allow specifying Grafana port via command-line arguments #2407

Closed negachov closed 4 months ago

negachov commented 5 months ago

What problem does this PR solve?

The Grafana port is fixed at 3000 and cannot be changed.

What is changed and how it works?

I have made it possible to specify the Grafana port via options.

Check List

Tests

Note: Version constraint is resolved to v8.0.0. If you'd like to use other versions:

Use exact version:      tiup playground v7.1.0
Use version range:      tiup playground ^5
Use nightly:            tiup playground nightly

Start pd instance:v8.0.0 Start tikv instance:v8.0.0 Start tidb instance:v8.0.0 Waiting for tidb instances ready 127.0.0.1:4000 ... Done Start tiflash instance:v8.0.0 Waiting for tiflash instances ready 127.0.0.1:3930 ... Done

πŸŽ‰ TiDB Playground Cluster is started, enjoy!

Connect TiDB: mysql --comments --host 127.0.0.1 --port 4000 -u root TiDB Dashboard: http://127.0.0.1:2379/dashboard Grafana: http://127.0.0.1:3333


Code changes

Side effects

Related changes

 - Need to update the documentation

Release notes:
<!--
If no, just leave the release note block below as is.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
Please refer to [Release Notes Language Style Guide](https://github.com/pingcap/tiup/blob/master/doc/dev/release-note-guide.md) before writing the release note.
-->
```release-note
NONE
CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

ti-chi-bot[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ti-chi-bot[bot] commented 5 months ago

Welcome @negachov! It looks like this is your first PR to pingcap/tiup πŸŽ‰

bohnen commented 5 months ago

+1 for this PR. The port 3000 is also the standard port in the Ruby on Rails community because it is the default port for running Rails in a local development environment. It is better to have an option to avoid conflicts.

ti-chi-bot[bot] commented 5 months ago

[LGTM Timeline notifier]

Timeline:

breezewish commented 5 months ago

/merge

bohnen commented 4 months ago

@breezewish It seems it stacked at tide check. Do you know if there is anything to do before merging?

breezewish commented 4 months ago

@bohnen Merged manually. Thanks for the report.