cluster: fix duplicated rename when enabling ms

pingcap / tiup

A component manager for TiDB

https://tiup.io

Apache License 2.0

409 stars 304 forks source link

cluster: fix duplicated rename when enabling ms #2409

Closed rleungx closed 2 weeks ago

rleungx commented 2 months ago

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kaaaaaaang commented 2 months ago

it is possible to overwrite exist file

rleungx commented 2 weeks ago

Close it since it is fixed by #2423