pdms: optimize upgrade pdms to avoid unnecessary primary transfer

pingcap / tiup

A component manager for TiDB

https://tiup.io

Apache License 2.0

425 stars 312 forks source link

pdms: optimize upgrade pdms to avoid unnecessary primary transfer #2414

Closed HuSharp closed 2 months ago

HuSharp commented 6 months ago

What problem does this PR solve?

What is changed and how it works?

ref https://github.com/tikv/pd/issues/7995

When we have 3 pdms, pdms-0/pdms-1/pdms-2, when pdms-2 is primary

upgrade pdms-2 firstly maybe transfer primary to pdms-0
and then uprade pdms-0 will transfer primary again

upgrade pdms primary in last place can avoid unnecessary primary transfer

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Release notes:

NONE

HuSharp commented 2 months ago

@xhebox PTAL, thx~

xhebox commented 2 months ago

/approve

ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [xhebox] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

xhebox commented 2 months ago

@xhebox PTAL, thx~

plz merge master

ti-chi-bot[bot] commented 2 months ago

[LGTM Timeline notifier]

Timeline:

2024-09-03 10:37:19.023452678 +0000 UTC m=+354363.541505603: :ballot_box_with_check: agreed by xhebox.
2024-09-04 02:04:13.941714236 +0000 UTC m=+409978.459767162: :heavy_multiplication_x::repeat: reset by HuSharp.
2024-09-04 02:10:27.686830395 +0000 UTC m=+410352.204883320: :ballot_box_with_check: agreed by xhebox.