playground: support scaling ms instances when using playground

rleungx commented 6 months ago

What problem does this PR solve?

close #2418

What is changed and how it works?

Check List

Tests

Manual test (add detailed scripts or steps below)

# xxx @ cloud-ecosystem-00 in ~/workspace/tiup on git:fix-health-check x [14:23:04]
$ bin/tiup-playground scale-out --tso 1

# xxx @ cloud-ecosystem-00 in ~/workspace/tiup on git:fix-health-check x [14:23:56]
$ bin/tiup-playground display
Pid      Role        Uptime
---      ----        ------
1664279  pd          50.760217075s
1664294  tso         50.047913364s
1668333  tso         5.790315547s
1664307  scheduling  49.294502817s
1664365  tikv        43.760522609s
1664865  tidb        43.38240817s
1665074  tiflash     34.235445093s

# xxx @ cloud-ecosystem-00 in ~/workspace/tiup on git:fix-health-check x [14:24:02]
$ bin/tiup-playground scale-in --pid 1664294
scale in tso success

# xxx @ cloud-ecosystem-00 in ~/workspace/tiup on git:fix-health-check x [14:24:11]
$ bin/tiup-playground display
Pid      Role        Uptime
---      ----        ------
1664279  pd          1m4.192541288s
1668333  tso         19.222638732s
1664307  scheduling  1m2.726825553s
1664365  tikv        57.192846277s
1664865  tidb        56.814730897s
1665074  tiflash     47.667768248s

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

kaaaaaaang commented 6 months ago

/approve

ti-chi-bot[bot] commented 6 months ago

@rleungx: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.14%. Comparing base (50abc4f) to head (70b6f30).

:exclamation: Current head 70b6f30 differs from pull request most recent head 09852d8. Consider uploading reports for the commit 09852d8 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2417 +/- ## ======================================= Coverage 50.14% 50.14% ======================================= Files 333 333 Lines 35867 35866 -1 ======================================= Hits 17984 17984 + Misses 15521 15520 -1 Partials 2362 2362 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2417/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [tiup](https://app.codecov.io/gh/pingcap/tiup/pull/2417/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `33.71% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kaaaaaaang commented 6 months ago

/lgtm

kaaaaaaang commented 6 months ago

/approve

ti-chi-bot[bot] commented 6 months ago

[LGTM Timeline notifier]

Timeline:

2024-05-09 07:25:53.380045768 +0000 UTC m=+1119707.137181336: :ballot_box_with_check: agreed by kaaaaaaang.
2024-05-13 05:32:47.73345497 +0000 UTC m=+1458521.490590543: :heavy_multiplication_x::repeat: reset by ti-chi-bot[bot].
2024-05-13 17:28:45.610124908 +0000 UTC m=+1501479.367260488: :ballot_box_with_check: agreed by kaaaaaaang.

ti-chi-bot[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

pingcap / tiup