Remove redundant config arg when launching pd

pingcap / tiup

A component manager for TiDB

https://tiup.io

Apache License 2.0

427 stars 313 forks source link

Remove redundant config arg when launching pd #2419

Closed ari-e closed 6 months ago

ari-e commented 6 months ago

What problem does this PR solve?

Redundant passing of --config command line argument to pd when launching playground.

What is changed and how it works?

Remove redundant line.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Ran manual test and it still works

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

ti-chi-bot[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

CLAassistant commented 6 months ago

All committers have signed the CLA.

ti-chi-bot[bot] commented 6 months ago

Welcome @ari-e! It looks like this is your first PR to pingcap/tiup 🎉

kaaaaaaang commented 6 months ago

/LGTM

ti-chi-bot[bot] commented 6 months ago

[LGTM Timeline notifier]

Timeline:

2024-05-27 08:17:27.858106283 +0000 UTC m=+2678001.615241856: :ballot_box_with_check: agreed by kaaaaaaang.