remove duplicate download when upgrade

pingcap / tiup

A component manager for TiDB

https://tiup.io

Apache License 2.0

409 stars 304 forks source link

remove duplicate download when upgrade #2423

Closed nexustar closed 1 month ago

nexustar commented 1 month ago

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

kaaaaaaang commented 1 month ago

/lgtm

kaaaaaaang commented 1 month ago

/approve

ti-chi-bot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ti-chi-bot[bot] commented 1 month ago

[LGTM Timeline notifier]

Timeline:

2024-05-30 08:53:44.71192989 +0000 UTC m=+2939378.469065447: :ballot_box_with_check: agreed by kaaaaaaang.
2024-05-30 08:54:01.404771009 +0000 UTC m=+2939395.161906580: :heavy_multiplication_x::repeat: reset by ti-chi-bot[bot].

ti-chi-bot[bot] commented 1 month ago

New changes are detected. LGTM label has been removed.

ti-chi-bot[bot] commented 1 month ago

@nexustar: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.