Cannot use 'tiup cluster edit-config xxx' to modify the tidb slow query file path - Githubissues

pingcap / tiup

A component manager for TiDB

https://tiup.io

Apache License 2.0

409 stars 304 forks source link

Cannot use 'tiup cluster edit-config xxx' to modify the tidb slow query file path #2428

Open tiancaiamao opened 2 weeks ago

tiancaiamao commented 2 weeks ago

Bug Report

Please answer these questions before submitting your issue. Thanks!

What did you do?

use tiup cluster edit-config xxx to edit the slow query file path server_configs: tidb: log.slow-query-file: /tidb-deploy/tidb-4000/log/testslow.log
reload the cluster: tiup cluster reload xxx
check the slow query file path, found the value is /tidb-deploy/tidb-4000/log/tidb_slow_query.log, it should be testslow.log

show config where name like '%slow%';

remove the slow-log command line configure from /tidb-deploy/deploy/tidb-4000/scripts/run_tidb.sh and then restart the cluster the new slow log path is used. But if tiup reload, it's overwrite again.

What did you expect to see?

Using 'tiup cluster edit-config' to modify slow query file path should work.

What did you see instead?

It does not work.

What version of TiUP are you using (tiup --version)?

master

seiya-annie commented 16 hours ago

/found customer