cluster: make pd mode editable

pingcap / tiup

A component manager for TiDB

https://tiup.io

Apache License 2.0

424 stars 312 forks source link

cluster: make pd mode editable #2431

Closed rleungx closed 4 months ago

rleungx commented 4 months ago

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

ti-chi-bot[bot] commented 4 months ago

[LGTM Timeline notifier]

Timeline:

2024-06-26 05:56:45.865696103 +0000 UTC m=+785532.351184934: :ballot_box_with_check: agreed by kaaaaaaang.

kaaaaaaang commented 4 months ago

/lgtm

kaaaaaaang commented 4 months ago

/approve

ti-chi-bot[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [kaaaaaaang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment