hide other password args - Githubissues

pingcap / tiup

A component manager for TiDB

https://tiup.io

Apache License 2.0

425 stars 312 forks source link

hide other password args #2436

Closed xhebox closed 4 months ago

xhebox commented 4 months ago

What problem does this PR solve?

As title.

Check List

Tests

Unit test
Integration test

Manual test (add detailed scripts or steps below)

[xhe@M1PRO-2 tiup]$ ./bin/tiup tidb-lightning:v6.5.3 --tidb-password tidb
Starting component tidb-lightning: /Users/xhe/.tiup/components/tidb-lightning/v6.5.3/tidb-lightning --tidb-password ******
Verbose debug logs will be written to /var/folders/4q/x954lkc95gl34qjnx2hbcr640000gn/T/lightning.log.2024-07-09T14.51.18+0800

No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

Redact `--tidb-password` arguments for tidb-lightning

xhebox commented 4 months ago

/approve

ti-chi-bot[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)~~ [xhebox] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ti-chi-bot[bot] commented 4 months ago

[LGTM Timeline notifier]

Timeline:

2024-07-10 03:23:49.58539108 +0000 UTC m=+414326.820625190: :ballot_box_with_check: agreed by bb7133.
2024-07-10 07:53:25.602794556 +0000 UTC m=+430502.838028661: :heavy_multiplication_x::repeat: reset by xhebox.
2024-07-12 07:58:26.40015249 +0000 UTC m=+603603.635386602: :ballot_box_with_check: agreed by bb7133.
2024-07-14 14:24:31.534695062 +0000 UTC m=+191093.525636532: :heavy_multiplication_x::repeat: reset by ti-chi-bot[bot].

ti-chi-bot[bot] commented 4 months ago

New changes are detected. LGTM label has been removed.

ti-chi-bot[bot] commented 4 months ago

@xhebox: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available [here](https://prow.tidb.net/command-help). If you have questions or suggestions related to my behavior, please file an issue against the [ti-community-infra/tichi](https://github.com/ti-community-infra/tichi/issues/new?title=Prow%20issue:) repository.

xhebox commented 4 months ago

/lgtm

ti-chi-bot[bot] commented 4 months ago

@xhebox: you cannot LGTM your own PR.

In response to [this](https://github.com/pingcap/tiup/pull/2436#issuecomment-2227371701): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.