TiFlash: Enable and inactive prof when start

pingcap / tiup

A component manager for TiDB

https://tiup.io

Apache License 2.0

424 stars 312 forks source link

TiFlash: Enable and inactive prof when start #2437

Closed CalvinNeo closed 4 months ago

CalvinNeo commented 4 months ago

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

ti-chi-bot[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

CalvinNeo commented 4 months ago

/cc @JaySon-Huang

ti-chi-bot[bot] commented 4 months ago

@CalvinNeo: GitHub didn't allow me to request PR reviews from the following users: JaySon-Huang.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/pingcap/tiup/pull/2437#issuecomment-2222243354): >/cc @JaySon-Huang Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

CalvinNeo commented 4 months ago

Error: download from https://tiup-mirrors.pingcap.com/grafana-v8.2.0-alpha-nightly-linux-amd64.tar.gz failed: read tcp 172.19.0.100:55558->43.152.135.107:443: read: connection reset by peer

CalvinNeo commented 4 months ago

/retest

CalvinNeo commented 4 months ago

/retest

ti-chi-bot[bot] commented 4 months ago

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiup/pull/2437#pullrequestreview-2173519424): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

CalvinNeo commented 4 months ago

/cc @xhebox @bb7133

ti-chi-bot[bot] commented 4 months ago

[LGTM Timeline notifier]

Timeline:

2024-07-12 06:48:50.81554493 +0000 UTC m=+599428.050779038: :ballot_box_with_check: agreed by xhebox.