search

pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
424 stars 312 forks source link

*: try to fix download racing bugs #2458

Closed xhebox closed 1 month ago

xhebox commented 2 months ago

What problem does this PR solve?

Close #2452

Check List

Tests

Code changes

Side effects

Related changes

Release notes:

Fix downloads racing bugs that results into 'No such file or directory'
ti-chi-bot[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from xhebox, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 44.21%. Comparing base (c1a14a5) to head (f3ab291). Report is 1 commits behind head on master.

:exclamation: Current head f3ab291 differs from pull request most recent head 2799709

Please upload reports for the commit 2799709 to get more accurate results.

Files with missing lines Patch % Lines
pkg/repository/v1_repository.go 33.33% 4 Missing and 2 partials :warning:
pkg/repository/v1manifest/local_manifests.go 0.00% 3 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (c1a14a5) and HEAD (f3ab291). Click for more details.

HEAD has 30 uploads less than BASE | Flag | BASE (c1a14a5) | HEAD (f3ab291) | |------|------|------| |unittest|2|0| |cluster|31|3|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2458 +/- ## =========================================== - Coverage 55.14% 44.21% -10.92% =========================================== Files 334 333 -1 Lines 36026 36108 +82 =========================================== - Hits 19863 15965 -3898 - Misses 13777 18001 +4224 + Partials 2386 2142 -244 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2458/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2458/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `35.18% <30.77%> (-9.59%)` | :arrow_down: | | [dm](https://app.codecov.io/gh/pingcap/tiup/pull/2458/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `25.16% <30.77%> (-0.09%)` | :arrow_down: | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2458/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `16.20% <25.00%> (+0.36%)` | :arrow_up: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2458/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ti-chi-bot[bot] commented 1 month ago

[LGTM Timeline notifier]

Timeline: