disable --collector.interrupts

pingcap / tiup

A component manager for TiDB

https://tiup.io

Apache License 2.0

425 stars 312 forks source link

disable --collector.interrupts #2463

Closed kaaaaaaang closed 2 weeks ago

kaaaaaaang commented 1 month ago

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release notes:

NONE

ti-chi-bot[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ti-chi-bot[bot] commented 1 month ago

[LGTM Timeline notifier]

Timeline:

2024-10-19 05:28:49.275596651 +0000 UTC m=+69729.972387262: :ballot_box_with_check: agreed by breezewish.

breezewish commented 1 month ago

Why is it removed?

kaaaaaaang commented 2 weeks ago

Why is it removed? 为什么它被删除了？

because it is not used in grafana dashboard, and it take lots of disk and ram space

kaaaaaaang commented 2 weeks ago

already fixed in https://github.com/pingcap/tiup/pull/2445