search

pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
424 stars 312 forks source link

add cdc server topylogy example #2466

Closed wk989898 closed 2 weeks ago

wk989898 commented 3 weeks ago

What problem does this PR solve?

What is changed and how it works?

As title.

Check List

Tests

Code changes

Side effects

Related changes

Release notes:

NONE
ti-chi-bot[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
CLAassistant commented 3 weeks ago

CLA assistant check
All committers have signed the CLA.

ti-chi-bot[bot] commented 3 weeks ago

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to [this](https://github.com/pingcap/tiup/pull/2466#pullrequestreview-2401012199): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
wk989898 commented 3 weeks ago

/retest

kaaaaaaang commented 3 weeks ago

/lgtm

ti-chi-bot[bot] commented 2 weeks ago

[LGTM Timeline notifier]

Timeline: