pingcap / tiup

A component manager for TiDB
https://tiup.io
Apache License 2.0
425 stars 312 forks source link

*: polish the trust key notice #2475

Closed breezewish closed 1 week ago

breezewish commented 2 weeks ago

What problem does this PR solve?

Currently when installing TiUP, a misleading warning will be displayed:

image

What is changed and how it works?

Only display the warning, when JSON is accessed via insecure Internet.

And also carefully polished the words, to avoid being mis-interpreted as System root certificate.

Check List

Tests

Release notes:

NONE
ti-chi-bot[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/pingcap/tiup/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 48.50%. Comparing base (505444d) to head (faf277c). Report is 2 commits behind head on master.

:exclamation: Current head faf277c differs from pull request most recent head 3856938

Please upload reports for the commit 3856938 to get more accurate results.

Files with missing lines Patch % Lines
pkg/localdata/profile.go 0.00% 3 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (505444d) and HEAD (faf277c). Click for more details.

HEAD has 1 upload less than BASE | Flag | BASE (505444d) | HEAD (faf277c) | |------|------|------| |unittest|1|0|
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2475 +/- ## ========================================== - Coverage 54.86% 48.50% -6.35% ========================================== Files 336 335 -1 Lines 36372 36360 -12 ========================================== - Hits 19953 17636 -2317 - Misses 14014 16397 +2383 + Partials 2405 2327 -78 ``` | [Flag](https://app.codecov.io/gh/pingcap/tiup/pull/2475/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | Coverage Δ | | |---|---|---| | [cluster](https://app.codecov.io/gh/pingcap/tiup/pull/2475/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `42.74% <0.00%> (-2.00%)` | :arrow_down: | | [playground](https://app.codecov.io/gh/pingcap/tiup/pull/2475/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `16.13% <50.00%> (+0.02%)` | :arrow_up: | | [unittest](https://app.codecov.io/gh/pingcap/tiup/pull/2475/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pingcap#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ti-chi-bot[bot] commented 1 week ago

[LGTM Timeline notifier]

Timeline: