Closed breezewish closed 1 week ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Attention: Patch coverage is 50.00000%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 48.50%. Comparing base (
505444d
) to head (faf277c
). Report is 2 commits behind head on master.:exclamation: Current head faf277c differs from pull request most recent head 3856938
Please upload reports for the commit 3856938 to get more accurate results.
Files with missing lines | Patch % | Lines |
---|---|---|
pkg/localdata/profile.go | 0.00% | 3 Missing :warning: |
:exclamation: There is a different number of reports uploaded between BASE (505444d) and HEAD (faf277c). Click for more details.
HEAD has 1 upload less than BASE
| Flag | BASE (505444d) | HEAD (faf277c) | |------|------|------| |unittest|1|0|
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Timeline:
2024-11-13 10:13:36.221995929 +0000 UTC m=+437578.412864919
: :ballot_box_with_check: agreed by kaaaaaaang.
What problem does this PR solve?
Currently when installing TiUP, a misleading warning will be displayed:
What is changed and how it works?
Only display the warning, when JSON is accessed via insecure Internet.
And also carefully polished the words, to avoid being mis-interpreted as System root certificate.
Check List
Tests
Release notes: