pingcap / website-docs

The next generation of PingCAP Docs. Powered by Gatsby ⚛️.
https://docs.pingcap.com/
MIT License
22 stars 33 forks source link

feat: adding missing alt text #465

Closed CBID2 closed 5 months ago

CBID2 commented 5 months ago

Issue

Closes #463

Description

This PR adds alt text to the icons on pingcap's doc website, making it easier for people who use screen readers to navigate the site.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website-docs ❌ Failed (Inspect) Jan 13, 2024 5:59am
vercel[bot] commented 5 months ago

@CBID2 is attempting to deploy a commit to the pingcap Team on Vercel.

A member of the Team first needs to authorize it.

Yuiham commented 5 months ago

The changes in the PR don't seem to solve the problem. Can you retry it the way I replied?

CBID2 commented 5 months ago

The changes in the PR don't seem to solve the problem. Can you retry it the way I replied?

Sure @Yuiham! :) Can you also put the 2024-tidb-docs-dash label on my PR too? For some odd reason, it got removed.

rpaik commented 5 months ago

The changes in the PR don't seem to solve the problem. Can you retry it the way I replied?

Sure @Yuiham! :) Can you also put the 2024-tidb-docs-dash label on my PR too? For some odd reason, it got removed.

This was also discussed on Discord. The 2024-tidb-docs-dash label is not applicable for this PR.

CBID2 commented 5 months ago

the way I replied

Done @Yuiham! :)

Yuiham commented 5 months ago

the way I replied

Done @Yuiham! :)

Thank you for your great contribution! But the docs git submodule commits in your branch need to be excluded from this PR. Otherwise, it will cause a doc site build error. Can you try to run the following git command once?

# Revert the submodule update commits
git revert --no-edit 00f3cf8...d450ed6

# Push reverting commits to remote
git push
Yuiham commented 5 months ago

LGTM for the rest

CBID2 commented 5 months ago

LGTM for the rest

Done @Yuiham