fix: `@uploadthing/mime-types` exports not supported in Expo

juliusmarminge commented 1 month ago

Closes https://github.com/pingdotgg/uploadthing/issues/999

flatten export paths since Expo doesn't resolve exports condition by default. This is similar to what we do for the main uploadthing package which has multiple entrypoints as well
modify file.slice() logic cause RN blobs suck

Summary by CodeRabbit

New Features
- Enhanced compatibility for the @uploadthing/mime-types package with legacy module resolutions in Expo.
- Improved file slicing mechanism for the upload functionality, optimizing file uploads by preventing unnecessary slicing.
Documentation
- Updated documentation for the createUpload function to include a warning about the limitations of resumable uploads in React Native.
Chores
- Restructured the @uploadthing/mime-types package to improve modularity and organization of MIME type exports.
- Updated the BASE_URL in the upload client to ensure correct API endpoint usage.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 80eaae5c32e4ef2616f24669d94378b9298afe9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

| Name | Type | | ----------------------- | ----- | | @uploadthing/mime-types | Patch | | uploadthing | Patch | | @uploadthing/shared | Patch | | @uploadthing/expo | Patch | | @uploadthing/nuxt | Patch | | @uploadthing/react | Patch | | @uploadthing/solid | Patch | | @uploadthing/svelte | Patch | | @uploadthing/vue | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-uploadthing	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 5, 2024 7:32pm

1 Skipped Deployment

pkg-pr-new[bot] commented 1 month ago

Open in Stackblitz

More templates

- [@example/minimal-appdir](https://pkg.pr.new/template/ea28487c-f404-408b-8354-5b6d625117f3) - [@example/minimal-expo](https://pkg.pr.new/template/c2068ba4-1b8c-48e6-a368-7467c8cb316f) - [@example/minimal-astro-react](https://pkg.pr.new/template/94962f75-afa7-4d7f-be43-21bbf57a8e9a) - [@example/minimal-nuxt](https://pkg.pr.new/template/5c1e4d81-7633-42f5-8971-156f1b68a11d) - [@example/minimal-pagedir](https://pkg.pr.new/template/c6be30b5-8285-4b76-bfff-ed2d7303b05a) - [@example/minimal-solidstart](https://pkg.pr.new/template/482c242c-87b0-4e7d-8f3e-ad2298e81eb9) - [@example/minimal-sveltekit](https://pkg.pr.new/template/28307ea9-f3a6-46dc-ac75-8cc9d1975712) - [@example/minimal-tanstack-start](https://pkg.pr.new/template/eeec98f0-59f5-402d-8f48-6590d7da02b0)

pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/mime-types@1013

pnpm add https://pkg.pr.new/pingdotgg/uploadthing@1013

commit: 80eaae5

github-actions[bot] commented 1 month ago

📦 Bundle size comparison

Bundle	Size (gzip)	Visualization
Main	27.50KB	See Treemap 📊
PR (a15c7533e22366a8a51dd059931d17f5e0552295)	27.51KB	See Treemap 📊
Diff	↑8.00B

coderabbitai[bot] commented 1 month ago

[!CAUTION]

Review failed

The pull request is closed.

Walkthrough

This pull request introduces several changes to enhance the functionality and compatibility of the @uploadthing/mime-types package and the upload functionality. Key modifications include a patch to support legacy module resolution in Expo, an update to the file slicing mechanism for uploads, and improvements to the documentation regarding resumable uploads in React Native. Additionally, the package.json and turbo.json files for the MIME types package have been restructured to improve modularity and output specifications.

Changes

File Path	Change Summary
.changeset/grumpy-spies-hunt.md	Added patch for `@uploadthing/mime-types` for legacy module resolution support in Expo.
.changeset/sixty-monkeys-smell.md	Introduced patch for file slicing in upload functionality to optimize upload efficiency.
docs/src/app/(docs)/api-reference/client/page.mdx	Updated documentation for `createUpload` to include a warning about resumable uploads in React Native.
packages/mime-types/package.json	Updated `exports` field and `files` array to reflect new paths for MIME types, enhancing modularity.
packages/mime-types/turbo.json	Modified `outputs` property in `build` task to include multiple directories for build outputs.
packages/uploadthing/src/internal/upload.browser.ts	Updated `uploadWithProgress` to conditionally slice files based on `rangeStart` parameter.
examples/backend-adapters/client-vanilla/src/uploadthing.ts	Changed `BASE_URL` from `"http://localhost:3003"` to `"http://localhost:3000"` for API requests.

Assessment against linked issues

Objective	Addressed	Explanation
Support legacy module resolution for Expo (#999)	✅
Fix file upload issues related to MIME types (#999)	✅

Possibly related PRs

#1013: This PR directly addresses the same package, @uploadthing/mime-types, focusing on enhancing compatibility with Expo, which aligns with the main PR's objective of improving legacy module resolution support for Expo.
#951: This PR includes updates to the @uploadthing/expo package, which is related to the main PR's focus on ensuring compatibility with Expo environments.
#978: This PR introduces enhancements to the upload functionality, which may relate to the overall improvements in handling uploads that the main PR aims to support.
#987: This PR discusses improvements to the withUt function, which may indirectly relate to the main PR's focus on ensuring proper functionality across different environments, including Expo.

Suggested reviewers

markflorkowski
t3dotgg

Poem

🐇 In the meadow where uploads play,
A patch was made to save the day.
Files now slice with care and grace,
In Expo's arms, they'll find their place.
With docs that guide through every twist,
Our uploads dance, they can't be missed! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

github-actions[bot] commented 1 month ago

A new canary is available for testing. You can install this latest build in your project with:

pnpm add @uploadthing/expo@7.0.4-canary.8bc74c6
pnpm add @uploadthing/mime-types@0.3.1-canary.8bc74c6
pnpm add @uploadthing/nuxt@7.0.4-canary.8bc74c6
pnpm add @uploadthing/react@7.0.4-canary.8bc74c6
pnpm add @uploadthing/shared@7.0.4-canary.8bc74c6
pnpm add @uploadthing/solid@7.0.4-canary.8bc74c6
pnpm add @uploadthing/svelte@7.0.4-canary.8bc74c6
pnpm add uploadthing@7.1.1-canary.8bc74c6
pnpm add @uploadthing/vue@7.0.4-canary.8bc74c6

Sorono-Dev commented 1 month ago

Working great and fix the issue that make Expo crash thank you

sudhanshug16 commented 3 weeks ago

Would love to get this merged :)

github-actions[bot] commented 2 weeks ago

A new canary is available for testing. You can install this latest build in your project with:

pnpm add @uploadthing/expo@7.1.1-canary.1d74d85
pnpm add @uploadthing/mime-types@0.3.2-canary.1d74d85
pnpm add @uploadthing/nuxt@7.1.1-canary.1d74d85
pnpm add @uploadthing/react@7.1.1-canary.1d74d85
pnpm add @uploadthing/shared@7.1.1-canary.1d74d85
pnpm add @uploadthing/solid@7.1.1-canary.1d74d85
pnpm add @uploadthing/svelte@7.1.1-canary.1d74d85
pnpm add uploadthing@7.2.1-canary.1d74d85
pnpm add @uploadthing/vue@7.1.1-canary.1d74d85

pingdotgg / uploadthing